This repository has been archived by the owner on Dec 14, 2021. It is now read-only.
fix: java path detection failures on linux #1138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
readlink was being invoked as "readlink" "-f path/to/java". It should've
been "readlink" "-f" "path/to/java" instead.
This can verified by running the tests and looking at the output of the
following command:
$ sudo execsnoop -q | grep readlink
readlink 2060 1925 0 "/nix/store/0y7rv26ffa359wvqd3js94cn73z882fg-coreutils-8.32/bin/readlink" "-f /nix/store/d5mpdil4c8z466f9zyxywxg5lm2zk3ls-openjdk-8u272-b10-jre/bin/java"
readlink 2081 1925 0 "/nix/store/0y7rv26ffa359wvqd3js94cn73z882fg-coreutils-8.32/bin/readlink" "-f /nix/store/xr5xm2bmfhd02v8h9ghzmhbcdc49ms55-openjdk-8u272-b10/lib/openjdk/jre/bin/java"
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
readlink was being invoked as
"readlink" "-f path/to/java". It should've been"readlink" "-f" "path/to/java"instead.This can verified by running the tests and looking at the output of the following command: